Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ESLint v9 compatibility layer #206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Oct 16, 2024

@MichaelDeBoey MichaelDeBoey requested review from ota-meshi and a team October 16, 2024 18:43
@MichaelDeBoey MichaelDeBoey self-assigned this Oct 16, 2024
@MichaelDeBoey MichaelDeBoey force-pushed the add-ESLint-v9-compat branch 4 times, most recently from 0707034 to 8c56516 Compare October 16, 2024 18:52
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (867f770) to head (9e8e0e8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   97.27%   97.35%   +0.08%     
==========================================
  Files          40       41       +1     
  Lines         403      416      +13     
==========================================
+ Hits          392      405      +13     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelDeBoey MichaelDeBoey force-pushed the add-ESLint-v9-compat branch 2 times, most recently from 02dee9f to a283662 Compare October 16, 2024 19:06
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs explanation, context, to be put into relation to #183 and eg justify additions and changes when this is a plugin that we should very much move away from (or justify to keep, see #183)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants