Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: env vars from secrets and configmap + values.schema update #21

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

PabloHiro
Copy link
Contributor

This is needed because environment variables can be defined from configMaps and/or Secrets.

Example:

extraEnv:
- name: KAFKA_SSL_TRUSTSTORE_PASSWORD 
  valueFrom: 
    secretKeyRef: 
      name: apicurio 
      key: user.password

This currently fails with:

Error: values don't meet the specifications of the schema(s) in the following chart(s):
apicurio-registry:
- registry.extraEnv.0: value is required
- registry.extraEnv.0: Additional property valueFrom is not allowed

Copy link
Owner

@eshepelyuk eshepelyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. address minor comments.
  2. plz add title attribute to previously added fields: initContainers, extraVolimes, extraVolumeMounts.

values.schema.json Outdated Show resolved Hide resolved
test/unit/deployment_registry.yaml Outdated Show resolved Hide resolved
@PabloHiro PabloHiro changed the title fix: env vars from secrets and configmaps fix: env vars from secrets and configmap + values.schema update Nov 21, 2023
@eshepelyuk eshepelyuk merged commit cbffe67 into eshepelyuk:main Nov 22, 2023
1 check passed
@eshepelyuk
Copy link
Owner

Thank you, will be abailable in 3.2.1
https://github.com/eshepelyuk/apicurio-registry-helm/releases/tag/3.2.1

@PabloHiro PabloHiro deleted the fix/envvars-support branch November 22, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants