Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initContainer support #19

Merged

Conversation

PabloHiro
Copy link
Contributor

No description provided.

Copy link
Owner

@eshepelyuk eshepelyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initContainers should be list of objects, i.e. default empty value will be []

test/linter/test.sh Outdated Show resolved Hide resolved
test/unit/initcontainer_registry_test.yaml Outdated Show resolved Hide resolved
test/unit/initcontainer_sync_test.yaml Outdated Show resolved Hide resolved
@PabloHiro
Copy link
Contributor Author

initContainers should be list of objects, i.e. default empty value will be []

I am copying implementation from:
https://github.com/tchiotludo/akhq/blob/dev/helm/akhq/templates/deployment.yaml#L52
Look at how they use it:
https://github.com/tchiotludo/akhq/blob/dev/helm/akhq/values.yaml#L80

If you prefer that I implement it as an array instead of a dict, I can go for it. Don't know what is the best practice to be honest. They use the dictionary key as the name field of the initContainer.

@eshepelyuk
Copy link
Owner

initContainers should be list of objects, i.e. default empty value will be []

I am copying implementation from: https://github.com/tchiotludo/akhq/blob/dev/helm/akhq/templates/deployment.yaml#L52 Look at how they use it: https://github.com/tchiotludo/akhq/blob/dev/helm/akhq/values.yaml#L80

If you prefer that I implement it as an array instead of a dict, I can go for it. Don't know what is the best practice to be honest. They use the dictionary key as the name field of the initContainer.

Pleaese declare initContainers as a list of objects.

@PabloHiro PabloHiro force-pushed the feature/init-containers-support branch from e888749 to bc57444 Compare November 17, 2023 22:38
@eshepelyuk eshepelyuk merged commit 55fc43b into eshepelyuk:main Nov 17, 2023
1 check passed
@PabloHiro PabloHiro deleted the feature/init-containers-support branch November 17, 2023 22:44
@eshepelyuk
Copy link
Owner

Thanks

Available in 3.1.0
https://github.com/eshepelyuk/apicurio-registry-helm/releases/tag/3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants