Remove "I have performed a self-review of my changes" from the pull request template #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing the "I have performed..." item from the template, as per our recent discussion, since the content seems to potentially be mis-understood. |
.github/workflows/ubuntu.yml
Outdated
| rebar3-version: '3' | ||
| rebar3-version: '3.23' |
There was a problem hiding this comment.
It automatically chose 3.24 so I'm pinning this down to have CI pass.
wojtekmach
approved these changes
Sep 25, 2024
We don't have a CLA but the guidelines should be help enough
paulo-ferraz-oliveira
force-pushed
the
unfeature/contributing-request-to-self-review
branch
from
919642b
to
dcef5d4
Compare
|
Thanks; merging... |
paulo-ferraz-oliveira
deleted the
unfeature/contributing-request-to-self-review
branch
|
Released in v1, v1.18 and v1.18.2. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't have a CLA but the guidelines should be help enough.