-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce action description in action.yml (GHA Marketplace constraint) #294
Conversation
Github marketplace requires a description be no longer than 125 chars.
Note: I also removed OTP 20 and elixir 1.14 from the test matrix. It was failing, but also they are both terribly old now. |
If you wanna do this (I don't think there's a maintenance range in place) I'd suggest getting rid of pre-20 info. in the README, too, as well as some of the unit tests ( |
action.yml
Outdated
Set up a BEAM-based CI environment, with Erlang/OTP as a base followed, optionally, by other | ||
elements, like Elixir, Gleam, `rebar3` or `hex`, on top of that. Check the [README](https://github.com/erlef/setup-beam) | ||
for updated information. | ||
Set up an Erlang/OTP based CI environment with support for languages and tooling such as Elixir, Gleam, rebar3, and `hex`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd specifically (recently) changed to have "BEAM-based", because you told me searching for BEAM yielded no results in the Marketplace. 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I changed it to this because I was trying to cram all the things in, do you have a better suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set up a BEAM-based CI environment, supporting languages and tools such as Erlang/OTP, Elixir, Gleam, `rebar3`, and `hex`.
😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'll work!
Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
README.md
Outdated
@@ -189,7 +189,7 @@ jobs: | |||
name: Erlang/OTP ${{matrix.otp}} / rebar3 ${{matrix.rebar3}} | |||
strategy: | |||
matrix: | |||
otp: ['20.3', '21.3', '22.2'] | |||
otp: ['21.3', '21.3', '22.2'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably remove this. It's a repeat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
derpy derp.
README.md
Outdated
@@ -165,7 +165,7 @@ jobs: | |||
name: OTP ${{matrix.otp}} / Elixir ${{matrix.elixir}} | |||
strategy: | |||
matrix: | |||
otp: ['20.3', '21.3', '22.2'] | |||
otp: ['21.3', '21.3', '22.2'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably remove this. It's a repeat.
Description
A brief description of your changes.
Github marketplace requires a description be no longer than 125 chars.