This repository has been archived by the owner on Sep 22, 2024. It is now read-only.
Fix a remote and a local crash scenario #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschroeder
commented
Dec 29, 2021
wschroeder
commented
- Some applications do not start supervisor children (CRITICAL)
- More safely handle race condition of ETS tables vanishing mid-query
This code filters out children that are not supervisors so we can avoid crashing remote processes that do not handle the which_children message. I marked this as critical, as monitoring should not crash remote systems.
The time between ets:all/0 and the series of ets:info/1 is enough time for tables that exist in ets:all/0's output to vanish in systems with temporary process trees. This code filters out the caught crashes due to the tables not existing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.