chore(ci): tell golangci-lint to report all issues #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, golangci-lint will only report a certain number of issues per linter and a certain number of the same issue per run. That adds unnecessary turnaround time when fixing issues. This PR updates our golangci-lint config file to tell the linter to report all errors. The golangci-lint config structure has changed quite a bit since v1.56, so rather than fight their docs I'm also upgrading the linter to the latest.
|
Ran into this config limitation while addressing linter issues on #764 |
This was referenced Aug 30, 2024
ocobles
approved these changes
Aug 30, 2024
|
This PR is included in version 2.4.1 🎉 |
1 similar comment
|
This PR is included in version 2.4.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, golangci-lint will only report a certain number of issues per linter and a certain number of the same issue per run. That adds unnecessary turnaround time when fixing issues.
This PR updates our golangci-lint config file to tell the linter to report all errors.
The golangci-lint config structure has changed quite a bit since v1.56, so rather than fight their docs I'm also upgrading the linter to the latest.