Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VRF support #358

Closed
wants to merge 5 commits into from
Closed

feat: VRF support #358

wants to merge 5 commits into from

Conversation

irusoeqx
Copy link
Contributor

@irusoeqx irusoeqx commented Oct 4, 2023

Hi guys,

Apologies that this took so long, but I was doing a bunch other things, but here I am committing the code that Marques fixed up along with some other functions, delete and list, I hope this is an alright starting point for whoever works on this next.

@irusoeqx irusoeqx temporarily deployed to external October 4, 2023 14:49 — with GitHub Actions Inactive
cprivitere
cprivitere previously approved these changes Oct 4, 2023
@cprivitere cprivitere dismissed their stale review October 4, 2023 14:55

tests failed

@displague displague linked an issue Oct 4, 2023 that may be closed by this pull request
@displague displague marked this pull request as draft October 4, 2023 17:37
@displague
Copy link
Member

displague commented Oct 4, 2023

Hi, @irusoeqx! Thanks for following up on #271.

It looks like a portion of the PR is missing compared to https://github.com/equinix/metal-cli/compare/main...displague:metal-cli:irusoeqx/main?diff=unified (specifically, cli.go, go.sum, and go.mod updates)

You can also see there are a number of linter and compile time errors highlighted in the file view:
https://github.com/equinix/metal-cli/pull/358/files

Try running the code and each action that has been added before pushing the next update, from the project root:

$ go run ./cmd/metal vrf help
$ go run ./cmd/metal vrf create --the-required-args
$ go run ./cmd/metal vrf list --the-required-args
$ go run ./cmd/metal vrf delete --the-required-args

@irusoeqx irusoeqx temporarily deployed to external October 5, 2023 08:37 — with GitHub Actions Inactive
@cprivitere cprivitere temporarily deployed to external October 9, 2023 19:20 — with GitHub Actions Inactive
@cprivitere
Copy link
Member

Hey @irusoeqx I rebased and ran the e2e tests for the current version of your PR, but it looks like the tests are still failing with various issues.

internal/vrf/delete.go Outdated Show resolved Hide resolved
Co-authored-by: Marques Johansson <mjohansson@equinix.com>
@irusoeqx irusoeqx temporarily deployed to external October 12, 2023 19:08 — with GitHub Actions Inactive
@irusoeqx irusoeqx temporarily deployed to external October 20, 2023 17:14 — with GitHub Actions Inactive
@codinja1188
Copy link
Contributor

/assign

@codinja1188
Copy link
Contributor

/assign @Vasubabu

@codinja1188
Copy link
Contributor

TC: #377

@aayushrangwala
Copy link
Contributor

@irusoeqx This PR #377 aims to add the same support. Please feel free to further contribute or close the PR in the favor of other

@displague
Copy link
Member

This PR became the basis for #377. Closing.

@displague displague closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for VRF features
5 participants