Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Unit test case for plans sub commands #304

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Added Unit test case for plans sub commands #304

merged 1 commit into from
Jul 20, 2023

Conversation

codinja1188
Copy link
Contributor

@codinja1188 codinja1188 commented Jul 12, 2023 •
edited
Loading

What this PR does / why we need it:

This PR was added to unit test cases for plans subcommands.

@codinja1188 codinja1188 force-pushed the plan-unit-test branch 2 times, most recently from 29d5229 to 62e9bcd Compare July 18, 2023 11:50
@ctreatma
Copy link
Contributor

Now that the e2e tests have been moved to a separate workflow, the e2e test files should be moved into the test/e2e directory and you can remove the testing.Short() check.

1 similar comment
@ctreatma
Copy link
Contributor

Now that the e2e tests have been moved to a separate workflow, the e2e test files should be moved into the test/e2e directory and you can remove the testing.Short() check.

@codinja1188 codinja1188 temporarily deployed to external July 18, 2023 15:19 — with GitHub Actions Inactive
ctreatma
ctreatma previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing

@ctreatma ctreatma dismissed their stale review July 18, 2023 21:41

testing required checks, wasn't a real review

@ctreatma ctreatma temporarily deployed to external July 18, 2023 21:41 — with GitHub Actions Inactive
@codinja1188 codinja1188 temporarily deployed to external July 19, 2023 16:57 — with GitHub Actions Inactive
@codinja1188 codinja1188 temporarily deployed to external July 19, 2023 17:19 — with GitHub Actions Inactive
@codinja1188 codinja1188 temporarily deployed to external July 20, 2023 12:14 — with GitHub Actions Inactive
ctreatma
ctreatma reviewed Jul 20, 2023
View reviewed changes
test/e2e/plan_test.go Outdated Show resolved Hide resolved
@codinja1188 codinja1188 temporarily deployed to external July 20, 2023 15:38 — with GitHub Actions Inactive
@ctreatma ctreatma temporarily deployed to external July 20, 2023 15:49 — with GitHub Actions Inactive
@displague displague merged commit 7557a91 into equinix:main Jul 20, 2023
5 checks passed
ctreatma
ctreatma reviewed Jul 20, 2023
View reviewed changes
test/e2e/plan_test.go
want: &cobra.Command{},
cmdFunc: func(t *testing.T, c *cobra.Command) {
root := c.Root()
root.SetArgs([]string{subCommand, "get", "--token", os.Getenv("METAL_AUTH_TOKEN"), "--filter", "type=standard"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vasubabu note that #309 was merged; that PR fixed environment lookup for testing, so if you rebase your remaining open PRs on the latest from main you won't need the --token flag any more in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctreatma ctreatma ctreatma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codinja1188 @ctreatma @displague