Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the mac build #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing the mac build #62

wants to merge 1 commit into from

Conversation

yasonk
Copy link

@yasonk yasonk commented Mar 7, 2019

A few issues were created for mac builds:
#60
#48

This code allowed me to install sent2vec using pip install .
Most of the code is copied from https://github.com/facebookresearch/fastText/blob/master/setup.py,
but had to also remove the rt library.

@mpagli
Copy link
Member

mpagli commented Mar 7, 2019

Thanks for the PR! I'll do some tests and come back to you hopefully by next Monday.

@yasonk
Copy link
Author

yasonk commented Mar 7, 2019

Not sure if it worked I'm getting a new error when I import and so far cannot resolve it:
In py36

import sent2vec
ImportError: dynamic module does not define module export function (PyInit_sent2vec)

In py27

ImportError: dynamic module does not define init function (initsent2vec)

@mpagli
Copy link
Member

mpagli commented Mar 27, 2019

I pulled your code and had the same issue on Ubuntu. Any luck on your side?

@yasonk
Copy link
Author

yasonk commented Mar 27, 2019

No, the only thing that I found was that the issue is not cython to python version issue (which seems to be the case here because both py2 and py3 are having the same issue). The only other time that people were able to resolve this issue was cython pulling invalid dependencies and generating a corrupted module (or something like that).

@kgarg8
Copy link

kgarg8 commented Jun 29, 2021

For me, the Mac build error got resolved by adding -std=libc++ to the compile-options as shown in the below link:

https://stackoverflow.com/questions/53809584/issues-about-installing-pcl-in-my-computer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants