[fix] [deps] update cheerio to fix dependency issue #2608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing, as I saw that it's already fixed in master, and it needs a cherry pick into the enzyme package, not a PR |
|
It doesn't need a cherry-pick, everything is exactly as it should be - it's just not released yet. Duplicate of #2558. |
glepretre
added a commit
to Kozea/formol
that referenced
this pull request
Sep 3, 2024
cheerio (https://github.com/cheeriojs/cheerio) has release an official 1.0.0 version after years of Release Candidate ones. cheeriojs/cheerio#4044 cheeriojs/cheerio#4032 cheeriojs/cheerio#3987 We depend on enzyme (https://github.com/enzymejs/enzyme) which depends on cheerio. Enzyme has not correctly locked cheerio RC version: enzymejs/enzyme@cafdb2b They're working on it... enzymejs/enzyme#2558 enzymejs/enzyme#2606 enzymejs/enzyme#2607 enzymejs/enzyme#2608 enzymejs/enzyme#2609 Meanwhile, locking cheerio here allow us to update our dependencies. According to enzyme, Cheerio RC was the last one supported by enzyme, even though RC12 seems to work for us.
glepretre
added a commit
to Kozea/formol
that referenced
this pull request
Sep 3, 2024
cheerio (https://github.com/cheeriojs/cheerio) has released an official 1.0.0 version after years of Release Candidate ones. cheeriojs/cheerio#4044 cheeriojs/cheerio#4032 cheeriojs/cheerio#3987 We depend on enzyme (https://github.com/enzymejs/enzyme) which depends on cheerio. Enzyme has not correctly locked cheerio RC version: enzymejs/enzyme@cafdb2b They're working on it... enzymejs/enzyme#2558 enzymejs/enzyme#2606 enzymejs/enzyme#2607 enzymejs/enzyme#2608 enzymejs/enzyme#2609 Meanwhile, locking cheerio here allow us to update our dependencies. According to enzyme, Cheerio RC was the last one supported by enzyme, even though RC12 seems to work for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2607