Initial version for animation with scene approach #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enables popping multiple views off the stack Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Rather than checking for the isManager flag which was inconsistently applied, a VM can call a private isManager method to determine if the provided view exists and is in its viewManagers hash. A consequence of this change is that VMs can only be declared within the managers[] and, when created manually, will always be considered a manager. Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
When using activate, the requestAnimationFrame caused a brief delay before the transition began which created an odd pause when releasing the drag. Using activateImmediate resolves this. Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Instead of overloading 'activate' with both views and manager and incongruently using 'deactivate' and 'dismiss' respectively for tear down, add a new 'manage' event for activation of a child ViewManager. Note that, for the time being, there is intentionally no post-transition event (like 'activated' for views) because the ViewManager's activation isn't animated in any way. Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Previously, transition completion was handled per-view so ViewLayout would fire its 'complete' event twice in most scenarios. Since ViewManager.direction to be reset when the first view transitioned, the event payload for the second view had an incorrect direction value. Furthermore, it doesn't make sense for 'complete' to fire until the entire transition is complete so it now monitors the state of both views' transition and only notifies when both are done. Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Issue: ENYO-2723 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
View activation is asynchronous (using rAF) so multiple calls to activate() in the same frame produced unexpected results and out of sync styling. For floating panels, the stack would only include the last view. For fixed panels, the direction could be incorrect if the penultimate activation was on the opposite side of the final activated view from the source view. Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Issue: ENYO-2714 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Issue: ENYO-2723 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Issue: ENYO-2714 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Issue: ENYO-2714 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Also add dragging property to distinguish between dismiss events Issue: PLAT-12048 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Fixes PLAT-12048 add dismiss event when dragging VM
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Altered ViewManager.draggable to be either Boolean or a String to support draggable, flickable, both or neither. Issue: PLAT-12457 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
Enyo-DCO-1.1-Signed-off-by: Anish Ramesan<anish.ramesan@lge.com>
Bug fixing related to fixed size array used to push among intermediate points in case of custom easing. Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Merge 2.6.0-dev into master.
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Anish Ramesan<anish.ramesan@lge.com>
Add matrix related modules within matrix module and vector related module within vector module. Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
…174-sceneapproach
Enyo-DCO-1.1-Signed-off-by: Anish Ramesan<anish.ramesan@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Added support for properties like translateX, rotateY, scaleZ, skewX etc. Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
With addition of various css like transform properties, e.g. translateX, rotateY etc, now we added support for multiple transform property within same animation like translateX and translateY. We also handled rotation property as it is not commutative. Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<ankur.mishra@lge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enyo-DCO-1.1-Signed-off-by: Anish Ramesananish.ramesan@lge.com