Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Product] Add RDS MySQL #2626

Merged
merged 32 commits into from
Mar 8, 2023
Merged

[New Product] Add RDS MySQL #2626

merged 32 commits into from
Mar 8, 2023

Conversation

CodaBool
Copy link
Contributor

@CodaBool CodaBool commented Mar 4, 2023

If you are wondering why you need another mysql release page. This proposed page would be for the AWS RDS releases. Which follow about a month behind and have their own end of life dates.

There is no AWS API to get End of life dates for RDS databases.

I wrote a script to scrape the dates on this page.

I also have another PR for postgres here

products/rds-mysql.md Outdated Show resolved Hide resolved
products/rds-mysql.md Outdated Show resolved Hide resolved
products/rds-mysql.md Outdated Show resolved Hide resolved
products/rds-mysql.md Outdated Show resolved Hide resolved
products/rds-mysql.md Outdated Show resolved Hide resolved
@CodaBool
Copy link
Contributor Author

CodaBool commented Mar 4, 2023

Looks great 🎉

I was able to add a latest column.

Screenshot 2023-03-04 161020

🤔 A consideration

I do have the data scraped for minor versions. I used markdown table format to add it to the page. It does end up looking nice

md-table

However,

I don't want to be making a PR every other month to update this minor table. So, I think I will omit this section since it's not even added as an API.

If there is a way to work this data into an API then I would be interested in maintaining it. I could set up some kind of automation for creating PRs with you guys. Since I do have the scraping script generate the markdown file for me already.

Let me know what you guys think of what to do with the minor version data. I personally would use it for my work if it exists. There are probably other people that would enjoy the available data. But I understand a /rds-postgres-minor page might be confusing as well as more overhead.

products/amazon-rds-mysql.md Outdated Show resolved Hide resolved
products/amazon-rds-mysql.md Outdated Show resolved Hide resolved
products/amazon-rds-mysql.md Outdated Show resolved Hide resolved
products/amazon-rds-mysql.md Outdated Show resolved Hide resolved
products/amazon-rds-mysql.md Outdated Show resolved Hide resolved
products/amazon-rds-mysql.md Show resolved Hide resolved
@marcwrobel
Copy link
Member

@captn3m0, I would like to have your opinion on this PR. Appart from the various Kubernetes distros we don't have much products like that.

Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions, thanks for creating this PR.

products/amazon-rds-mysql.md Outdated Show resolved Hide resolved
products/amazon-rds-mysql.md Outdated Show resolved Hide resolved
products/amazon-rds-mysql.md Outdated Show resolved Hide resolved
@captn3m0
Copy link
Member

captn3m0 commented Mar 7, 2023

Side note on our integration efforts wrt identifiers: While we're relying on PURLs to identify packages in SBOMs, cloud services have no such similar identifier.

So if a tool (and there's many) scans a cloud environment (say AWS), it will generate a report listing down installed versions of various products, such as RDS/EKS/AKS/GKE/Looker etc.

While we publish EOL data of these, there's no easy way for such tools to use our dataset to link back.

I'd raised this with PURL, and it seems that PURLs will stick to "installable packages", which these cloud services are not. So we need a better way.

CycloneDX wants to standardize SaaSSBOMs so my hope is to use whatever identifiers they settle on. (See https://github.com/CycloneDX/bom-examples/tree/master/SaaSBOM for current progress).

If this doesn't work out, I'd like to figure out a cloud-service:// identifier, similar to PURLs with a simple conversion against AWS ARNs, and other similar IDs.

marcwrobel and others added 3 commits March 7, 2023 17:40
Co-authored-by: Nemo <me@captnemo.in>
Co-authored-by: Nemo <me@captnemo.in>
Co-authored-by: Nemo <me@captnemo.in>
@marcwrobel marcwrobel requested a review from captn3m0 March 7, 2023 16:42
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed it and LGTM. @captn3m0 to you want to do a final review ?

@captn3m0 captn3m0 merged commit 124f6e4 into endoflife-date:master Mar 8, 2023
@welcome
Copy link

welcome bot commented Mar 8, 2023

Thank you and congratulations for your first contribution! endoflife.date is a community wiki, and we're always looking for more contributions 🥇 💯 🎉.

@captn3m0
Copy link
Member

captn3m0 commented Mar 8, 2023

Enabled the releaseDate column, merged. Thanks a lot for your contribution @CodaBool 🎉.

Depending on feedback, I'd open to switching to listing multiple minor versions as well, if that's more helpful.

@marcwrobel marcwrobel added the new-product This PR adds a new product to the website. label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants