feat: implement DeserializerOptions, and use it to add a new option integers_as_floats
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…integers_as_floats`
Gutawer
changed the title
integers_as_floatsDeserializerOptions, and use it to add a new option integers_as_floats
|
Could you include a unit test to show this new functionality? |
|
Yep happy to though it’ll be a couple of days until I can - there are tests in the form of doc examples but yeah I’m happy to contribute a more substantial test suite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131 - decided I might as well PR this since it's not too much effort. Happy to make any requested changes and talk about the design but this is what I had in mind with my comment on the issue ticket :)
Adds an opt-in-per-call flag for accepting integers where floats are accepted, helping ergonomics when parsing data from languages like Python or typst where the distinction between ints and floats still exists, but is much weaker than Rust forcing you to convert explicitly always.