Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http1 integration tests missing :requires_internet_connection tag #443

Merged

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Jul 1, 2024

This should resolve the errors when excluding test with :requires_internet_connection tag for http1 tests using the following command.

mix test --exclude requires_internet_connection

This should resolve the errors when excluding test with
:requires_internet_connection tag for http1 tests using the following
command.

    mix test --exclude requires_internet_connection
@kianmeng
Copy link
Contributor Author

kianmeng commented Jul 1, 2024

The mentioned error:

$ mix test --exclude requires_internet_connection
Running ExUnit with seed: 329366, max_cases: 24                                                                                           
Excluding tags: [:requires_internet_connection, :proxy]             
                                                                     
....................................................................................                                                      
                                                                                                                                          
  1) test twitter.com timeout with http (Mint.HTTP1.IntegrationTest)
     test/mint/http1/integration_test.exs:104
     match (=) failed                                                
     code:  assert {:error, %TransportError{reason: :timeout}} =                                                                          
              HTTP1.connect(:http, "twitter.com", 80, transport_opts: [timeout: 0])
     left:  {:error, %Mint.TransportError{reason: :timeout}}                                                                              
     right: {:error, %Mint.TransportError{reason: :nxdomain, __exception__: true}}
     stacktrace:                                                     
       test/mint/http1/integration_test.exs:105: (test)
                                                                                                                                          
.................                                                                                                                         
                                                                                                                                          
  2) test twitter.com timeout with https (Mint.HTTP1.IntegrationTest)
     test/mint/http1/integration_test.exs:109          
     match (=) failed
     code:  assert {:error, %TransportError{reason: :timeout}} =                                                                          
              HTTP1.connect(:https, "twitter.com", 443, transport_opts: [timeout: 0])                                                     
     left:  {:error, %Mint.TransportError{reason: :timeout}}
     right: {:error, %Mint.TransportError{reason: :nxdomain, __exception__: true}}
     stacktrace:
       test/mint/http1/integration_test.exs:110: (test)
...

@coveralls
Copy link

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build a2eeaa494557661cca3c5ae613d0f6c0b6c777ae-PR-443

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.389%

Totals Coverage Status
Change from base Build 61f0989bf26e014a2c165295a38123792c662206: 0.0%
Covered Lines: 1275
Relevant Lines: 1459

💛 - Coveralls

Copy link
Contributor

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto! 💟

@whatyouhide whatyouhide merged commit 76a6d40 into elixir-mint:main Jul 1, 2024
3 checks passed
@kianmeng
Copy link
Contributor Author

kianmeng commented Jul 2, 2024

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants