Don't send RST_STREAM when not needed #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the stream state is local_half_closed and an end_stream flag is received, the stream can be terminated normally without RST_STREAM.
Pull Request Test Coverage Report for Build e6a3aac052f01725352df867c357cb80818e034f-PR-434Details
💛 - Coveralls |
|
This is a WIP, I'm opening for reference. I need to double check some corner cases and maybe my implementation can be simplified. |
v0idpwn
commented
May 9, 2024
| # We send a RST_STREAM with the given error code so that we move the | ||
| # stream to the :closed state (that is, we remove it). | ||
| open?(conn) -> | ||
| error_code = if reason == :remote_end_stream, do: :no_error, else: reason |
There was a problem hiding this comment.
I don't think this line is ever used, but it doesn't feel right to remove it (?)
v0idpwn
commented
May 9, 2024
|
Also it looks like CI is failing for totally unrelated reasons™️ |
Yes Totally Unrelated™, no worries
@v0idpwn is this ready to review? |
|
Yes! |
|
Woot woot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the stream state is local_half_closed and an end_stream flag is received, the stream can be terminated normally without RST_STREAM.
Closes #433.
I still didn't work on integration tests, and while current tests kind of cover this feature, I'll add a specific test for it.