Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether CAStore is available in compile-time #428

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

v0idpwn
Copy link
Contributor

@v0idpwn v0idpwn commented Apr 17, 2024

Removes the cost of calling Code.ensure_loaded?/1 every time that credentials are not provided.

Removes the cost of calling `Code.ensure_loaded?/1` every time that
credentials are not provided.
lib/mint/core/transport/ssl.ex Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 17, 2024

Pull Request Test Coverage Report for Build 1dbeeeea825c06aa4a60aabbe1a053f358d08bd2-PR-428

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 87.879%

Totals Coverage Status
Change from base Build 530ba279d919b17a903f10ac9aeb39baf8c019e3: 0.06%
Covered Lines: 1276
Relevant Lines: 1452

💛 - Coveralls

Co-authored-by: Eric Meadows-Jönsson <eric.meadows.jonsson@gmail.com>
@whatyouhide
Copy link
Contributor

Good catch, thanks @v0idpwn 💟

@whatyouhide whatyouhide merged commit c5f3ed6 into elixir-mint:main Apr 17, 2024
4 checks passed
@v0idpwn v0idpwn deleted the comp-time-optimization branch April 17, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants