Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate :read_write option on HTTP.open?/2 #426

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

ericmj
Copy link
Member

@ericmj ericmj commented Feb 12, 2024

Closes #410.

@coveralls
Copy link

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 936c36337beeef8226e11a258785a80d020df527-PR-426

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 32 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.3%) to 87.818%

Files with Coverage Reduction New Missed Lines %
lib/mint/core/transport/tcp.ex 1 95.65%
lib/mint/unsafe_proxy.ex 1 34.21%
lib/mint/http.ex 13 62.86%
lib/mint/core/transport/ssl.ex 17 87.22%
Totals Coverage Status
Change from base Build 74e0ec62d9efe26409fdb7c40181958291a72f3f: 0.3%
Covered Lines: 1276
Relevant Lines: 1453

💛 - Coveralls

Copy link
Contributor

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left only one comment, LGTM otherwise! 👏

lib/mint/http1.ex Show resolved Hide resolved
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
@ericmj ericmj merged commit 530ba27 into main Feb 13, 2024
4 checks passed
@ericmj ericmj deleted the ericmj/deprecate-read-write branch February 13, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing Mint.HTTP2.open?/2
3 participants