Fix WheelTimer implementation that can expired timeout early #17850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When entries insert in the end of timer queue, then unnecessary entry inserted (with duplicated key).
This can lead to some timeouts expired early and consume memory.
This can be checked with following test (to this file)
Look at the entries after obj2 insert:
gaps and duplicates cause errors when search Entry to insert in the middle of queue:
self.entries[max(min_key, then_key) - min_key].elements.add(obj)
This Pull request fix this with some minor refactoring (remove
current_tick
unused variable) and add this test case to unit tests.