Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal text extra line space '\n' resolved #8765

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sufyan-amoodi
Copy link

@sufyan-amoodi sufyan-amoodi commented Feb 21, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

In the "EventHtmlRenderer.kt" file under the "removeLeadingNewlineForInlineElement" function we have added an expression that removes extra line spaces from normal text as well. The solution under the function focuses only on the formatted text lines. After making changes to the same function, we were able to resolve for the normal text lines as well.

Motivation and context

[(https://github.com//issues/8764#issue-2144036397)]

Screenshots / GIFs

Before Screenshot_20240220_125700_Element After Screenshot_20240221_121252_Element - dbg

Tests

  • Cloned the element-android project
  • Added the changes (on the developer branch) and ran the project on a physical android device
  • The changes were successfully reflected on the android device

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sdev1 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants