Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for default gemfile instead on bundler directory #1477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smedrick
Copy link

@smedrick smedrick commented Aug 1, 2024

What does this pull request do?

When the stacktrace helper attempts to find the path of installed gems, it uses a method to verify a default bundler install path that attempts to write to the filesystem. This behavior prevents the apm agent from running on a read-only filesystem. This PR attempts to keep the spirit of the functionality while getting around the need to write to the filesystem. Instead of checking if there is a default bundler path, it checks to see if there's a default gemfile.

Why is it important?

Without this bug fix, we cannot run the agent on apps in our secure k8s cluster.

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

  • Closes 1464

Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
8acfac1

Please, read and sign the above mentioned agreement if you want to contribute to this project

@estolfo
Copy link
Contributor

estolfo commented Sep 24, 2024

Hi @smedrick thanks for this PR. Did you find this as the result of an error? I just wanted to see if I could reproduce it. Also, if you could sign the CLA, that'd be great.

@smedrick
Copy link
Author

Hi @smedrick thanks for this PR. Did you find this as the result of an error? I just wanted to see if I could reproduce it. Also, if you could sign the CLA, that'd be great.

This addresses #1464

I did sign the CLA but I have no idea how it links back to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants