code review changes

src/etos_test_runner/lib/testrunner.py

@@ -27,9 +27,12 @@
 from etos_test_runner.lib.log_area import LogArea
 from etos_test_runner.lib.verdict import CustomVerdictMatcher
 
+
 class TestRunner:
     """Test runner for ETOS."""
 
+    # pylint: disable=too-many-instance-attributes
+
     logger = logging.getLogger("ETR")
 
     def __init__(self, iut, etos):
@@ -58,8 +61,6 @@ def __init__(self, iut, etos):
             rules = []
 
         self.verdict_matcher = CustomVerdictMatcher(rules)
-        self.test_framework_exit_codes = []
-
 
     def test_suite_started(self):
         """Publish a test suite started event.
@@ -131,7 +132,11 @@ def run_tests(self, workspace: Workspace) -> tuple[bool, list[Union[int, None]]]
         return result, test_framework_exit_codes
 
     def outcome(
-        self, result: bool, executed: bool, description: str, test_framework_exit_codes: list[Union[int, None]]
+        self,
+        result: bool,
+        executed: bool,
+        description: str,
+        test_framework_exit_codes: list[Union[int, None]],
     ) -> dict:
         """Get outcome from test execution.
 
@@ -154,8 +159,10 @@ def outcome(
                 verdict = custom_verdict["verdict"]
                 description = custom_verdict["description"]
             except KeyError as err:
-                raise ValueError(f"Malformed entry in the verdict rule file: {custom_verdict}. "
-                                 "Expected attributes: description, condition, conclusion, verdict.") from err
+                raise ValueError(
+                    f"Malformed entry in the verdict rule file: {custom_verdict}. "
+                    "Expected attributes: description, condition, conclusion, verdict."
+                ) from err
             self.logger.info("Verdict matches testrunner verdict rule: %s", custom_verdict)
         elif executed:
             conclusion = "SUCCESSFUL"

src/etos_test_runner/lib/verdict.py

@@ -57,12 +57,13 @@ def __init__(self, rules: list) -> None:
     def _evaluate_rule(self, rule: dict, test_framework_output: dict) -> bool:
         """Evaluate conditions within the given rule."""
         for kw, expected_value in rule["condition"].items():
-            # If the condition has multiple expressions, they are implicitly joined using logical AND:
-            # i. e. all shall evaluate to True in order for the condition to be True.
+            # If the condition has multiple expressions, they are implicitly
+            # joined using logical AND: i. e. all shall evaluate to True
+            # in order for the condition to be True.
             # False is returned as soon as a false statement is encountered.
             if kw == "test_framework_exit_code":
-                # If the exit code given by the condition is found in the list of produced exit codes,
-                # the rule will evaluate as True.
+                # If the exit code given by the condition is found in
+                # the list of produced exit codes, the rule will evaluate as True.
                 if expected_value not in test_framework_output.get("test_framework_exit_codes"):
                     return False
         return True
@@ -73,4 +74,3 @@ def evaluate(self, test_framework_output: dict) -> Union[dict, None]:
             if self._evaluate_rule(rule, test_framework_output):
                 return rule
         return None
-