Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement log level changes and improvements for REMReM and Translator #275

Merged
merged 9 commits into from
Aug 28, 2023

Conversation

vishnu-alapati
Copy link
Contributor

@vishnu-alapati vishnu-alapati commented Aug 16, 2023

Applicable Issues

Description of the Change

While the log level is INFO, we are not seeing eventID and HttpStatus code in catalina files. So, Made the necessary changes to print them.

Alternate Designs

Benefits

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Vishnu Alapati vishnu.alapati@tcs.com

Copy link
Contributor

@piyush-sadangi piyush-sadangi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@z-sztrom z-sztrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo in the code. Otherwise it looks fine and tests passed.

Copy link
Contributor

@z-sztrom z-sztrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@vishnu-alapati vishnu-alapati changed the title Investigate necessary log level changes REMReM and Translator Implement log level changes and improvements for REMReM and Translator Aug 28, 2023
@jainadc9 jainadc9 merged commit 3be9ff8 into eiffel-community:master Aug 28, 2023
1 check passed
@vishnu-alapati vishnu-alapati deleted the EIFA-1203 branch August 28, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants