-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented changes to adapt routingkey template to sepia #247
Conversation
* Updated main.yml and test files
publish-cli/src/main/java/com/ericsson/eiffel/remrem/publish/cli/CliOptions.java
Outdated
Show resolved
Hide resolved
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Outdated
Show resolved
Hide resolved
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Outdated
Show resolved
Hide resolved
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, define constants instead of using strings in code.
@jainadc9 do you have any answers to the review comments on this PR? |
* Rebase changes with master * Update CHANGELOG.md
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Outdated
Show resolved
Hide resolved
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Do we have a test case for routing key file?
- There's a lot of occurences ...Routingkey... It should use uppercase k ('K') instead.
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/PublishUtils.java
Outdated
Show resolved
Hide resolved
publish-cli/src/main/java/com/ericsson/eiffel/remrem/publish/cli/CliOptions.java
Show resolved
Hide resolved
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Outdated
Show resolved
Hide resolved
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Outdated
Show resolved
Hide resolved
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Outdated
Show resolved
Hide resolved
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine.
It looks good to me |
Applicable Issues
Description of the Change
Implemented changes to adapt routingkey template to sepia
Alternate Designs
Benefits
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: JainadC jainad.chinta@ericsson.com