Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SrcFile's debug should not print the whole content #449

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

yihozhang
Copy link
Collaborator

@yihozhang yihozhang commented Oct 20, 2024

Fixes #447

Before:

> RUST_LOG=debug cargo run --release tests/python_array_optimize.egg 2>&1 >/dev/null | wc 
   26609 14906607 220858043

After:

> RUST_LOG=debug cargo run --release tests/python_array_optimize.egg 2>&1 >/dev/null | wc
   26610  788211 10508203

@yihozhang yihozhang requested a review from oflatt October 20, 2024 19:38
@yihozhang yihozhang requested a review from a team as a code owner October 20, 2024 19:38
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #449 will degrade performances by 9.09%

Comparing fix-debug-print (d9e4ce0) with main (5d637f2)

Summary

⚡ 3 improvements
❌ 3 regressions
✅ 80 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-debug-print Change
bool 1.3 ms 1.4 ms -5.87%
combined-nested 1,025.1 µs 943.8 µs +8.61%
datatypes 589.4 µs 546.7 µs +7.81%
delete 645.6 µs 601.5 µs +7.34%
string 498.4 µs 545.5 µs -8.63%
string_quotes 432.6 µs 475.9 µs -9.09%

@saulshanabrook saulshanabrook merged commit b0db068 into main Oct 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug prints entire program every time
2 participants