Fix eval_lit performance bug
#441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! How does the flamegraph now look like for |
|
I think something's wrong with my flamegraphs, but I'm getting ~10s now compared to ~25s before. main: this branch: |
|
We didn't get there in the meeting, but would there be interest in adding codspeed tracking? They support flamegraphs in CI and will also show the diff in the flamegraph between a PR and main, showing which parts improved and which parts were degraded. If there is, I am happy to add it. |
|
I'm keeping this PR open to test with codspeed, but I will close it afterwards because it's subsumed by #442 . |
Alex-Fischman
force-pushed
the
eval-lit-performance
branch
from
6d63b60
to
840308a
Compare
CodSpeed Performance ReportMerging #441 will improve performances by 17.21%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the performance bug in
eval_litas noticed by Yihong in 439.