Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless type_info getters #429

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

Alex-Fischman
Copy link
Contributor

This PR removes the type_info and type_info_mut from the EGraph struct, since having a mutable getter that doesn't do anything else doesn't make sense.

Happy to close this PR if there is a reason for these functions, but only if that reason is documented.

@Alex-Fischman Alex-Fischman requested a review from a team as a code owner October 4, 2024 02:45
@Alex-Fischman Alex-Fischman requested review from yihozhang and removed request for a team October 4, 2024 02:45
Copy link
Collaborator

@yihozhang yihozhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! AFAIR, the getter is here because type_info used to live in Desugar, not directly under EGraph

Copy link
Member

@saulshanabrook saulshanabrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Alex-Fischman Alex-Fischman merged commit 0d4e688 into egraphs-good:main Oct 5, 2024
3 checks passed
@Alex-Fischman Alex-Fischman deleted the type_info_getters branch October 5, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants