Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code #428

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Remove dead code #428

merged 3 commits into from
Oct 5, 2024

Conversation

yihozhang
Copy link
Collaborator

@yihozhang yihozhang commented Oct 3, 2024 •
edited
Loading

This PR

  • removes the following options: proofs_enabled, terms_enabled, match_limit, and node_limit, since they are currently dead code and does nothing.
  • removes the make_defaults in the run_actions function since it is always set to true.

Closes #318

@yihozhang yihozhang requested a review from a team as a code owner October 3, 2024 00:07
@yihozhang yihozhang requested review from mwillsey and oflatt and removed request for a team October 3, 2024 00:07
saulshanabrook
saulshanabrook approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@saulshanabrook saulshanabrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray, removing code!

@Alex-Fischman Alex-Fischman mentioned this pull request Oct 4, 2024
Closed
@Alex-Fischman Alex-Fischman merged commit 606459d into main Oct 5, 2024
6 checks passed
@Alex-Fischman Alex-Fischman deleted the yihozhang-remove-node-limit branch October 5, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulshanabrook saulshanabrook saulshanabrook approved these changes

@mwillsey mwillsey Awaiting requested review from mwillsey mwillsey is a code owner automatically assigned from egraphs-good/egglog-reviewers

@oflatt oflatt Awaiting requested review from oflatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary arguments to eval_expr and run_actions
3 participants
@yihozhang @saulshanabrook @Alex-Fischman