Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and adds extra tests to BDD & Arrays #187

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

TrevorHansen
Copy link
Contributor

@TrevorHansen TrevorHansen commented Aug 12, 2023

For BDD, this:
(1) fixes some operations,
(2) reduces the number of rewrites required by adding commutative operations, (3) adds more tests,
(4) moves the tests into a separate frame so that the changes made during testing are cleaned up when testing finishes.

For arrays, this adds a necessary addition rewrite.

This: 
(1) fixes some BDD operatons, 
(2) reduces the number of rewrites required by adding commutative operations, 
(3) adds more tests,
(4) moves the tests into a separate frame so that the changes made during testing are cleaned up when testing finishes.
includes this:
 (rewrite (add x (Num 0)) x)
(rewrite (or False x) x)
(rewrite (or x False) x)
(rewrite (or (ITE n a1 a2) (ITE m b1 b2))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this uses "b1" & "b2" which have been defined above in the test code. So these aren't free variables.

@TrevorHansen TrevorHansen changed the title Fixes and adds extra tests to BDD Fixes and adds extra tests to BDD & Arrays Aug 14, 2023
@mwillsey mwillsey merged commit 098ef18 into egraphs-good:main Aug 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants