Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Term Encoding #158

Closed
wants to merge 152 commits into from
Closed

Conversation

oflatt
Copy link
Member

@oflatt oflatt commented Jun 28, 2023

No description provided.

@@ -0,0 +1,148 @@
use crate::{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO migrate to new EGraph package instead of termdag

oflatt and others added 6 commits July 20, 2023 14:16
Co-authored-by: Oliver Flatt <oflatt@gmail.com>
Co-authored-by: Oliver Flatt <oflatt@gmail.com>
Also push them up in queries.

Co-authored-by: Oliver Flatt <oflatt@gmail.com>
Co-authored-by: Oliver Flatt <oflatt@gmail.com>
Co-authored-by: Oliver Flatt <oflatt@gmail.com>
@oflatt
Copy link
Member Author

oflatt commented Jul 27, 2023

Update on this PR: A couple benchmarks are 100x slower due to the new encoding,
Max and I are working on making the query compiler smarter / changing the encoding to get back the performance.

@oflatt
Copy link
Member Author

oflatt commented Jul 31, 2023

Closing for now- this will probably be the right way to do things, but we need a better backend.

@oflatt oflatt closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants