Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align names between tmp file and what cfg generator expects #647

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

ajpal
Copy link
Collaborator

@ajpal ajpal commented Oct 31, 2024

No description provided.

@ajpal ajpal requested a review from oflatt October 31, 2024 20:20
@@ -21,12 +21,12 @@ def make_cfgs(bench, data_dir):
opt = "opt"

# https://llvm.org/docs/Passes.html#dot-cfg-print-cfg-of-function-to-dot-file
cmd = f"{opt} -disable-output -passes=dot-cfg {bench}-{mode}.ll"
cmd = f"{opt} -disable-output -passes=dot-cfg {bench}-{mode}-{mode}.ll"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is gross....

@ajpal
Copy link
Collaborator Author

ajpal commented Oct 31, 2024

profile.py has gotten kind of out of control. I think it needs a big cleanup, but this PR is just a targeted fix for this issue

Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ajpal ajpal merged commit 774b7f7 into main Oct 31, 2024
4 checks passed
@ajpal ajpal deleted the ajpal-fix-cfgs branch October 31, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants