fix radio buttons on firefox

egraphs-good · Oct 30, 2024 · 5b23b9d · 5b23b9d
1 parent c398df5
commit 5b23b9d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/infra/nightly-resources/handlers.js b/infra/nightly-resources/handlers.js
@@ -12,6 +12,11 @@ async function load_index() {
   selectAllModes(true);
   selectAllBenchmarks(true);
 
+  // Firefox doesn't handle radio buttons correctly on page reload,
+  // so manually set to absolute view
+  document.getElementById("absolute").checked = true;
+  onRadioClick("absolute");
+
   const previousRuns = await getPreviousRuns();
   const initialRunIdx = findBenchToCompareIdx(previousRuns);
   loadBaseline(previousRuns[initialRunIdx].url);
@@ -111,10 +116,10 @@ async function loadBaseline(url) {
   refreshView();
 }
 
-function onRadioClick(elt) {
-  GLOBAL_DATA.chart.mode = elt.value;
+function onRadioClick(value) {
+  GLOBAL_DATA.chart.mode = value;
   document.getElementById("speedup-formula").style.visibility =
-    elt.value === "speedup" ? "visible" : "hidden";
+    value === "speedup" ? "visible" : "hidden";
   refreshChart();
 }
 

diff --git a/infra/nightly-resources/index.html b/infra/nightly-resources/index.html
@@ -23,9 +23,9 @@ <h2>Profile</h2>
   <div>
     <button type="button" class="collapsible" onclick="toggle(this, '\u25B6 Show Chart', '\u25BC Hide Chart')">&#x25BC; Hide Chart</button>
     <div class="expanded">
-      <input onclick="onRadioClick(this);" checked type="radio" id="absolute" name="chart-type" value="absolute">
+      <input onclick="onRadioClick('absolute');" checked type="radio" id="absolute" name="chart-type" value="absolute">
       <label for="absolute">Absolute</label>
-      <input onclick="onRadioClick(this);" type="radio" id="speedup" name="chart-type" value="speedup">
+      <input onclick="onRadioClick('speedup');" type="radio" id="speedup" name="chart-type" value="speedup">
       <label for="speedup">Speedup</label><br>
       <p id="speedup-formula">Speedup = (LLVM-O0 TIME / RUN MODE TIME)</p>
       <canvas class="content" id="chart"></canvas>