Hf referral new digit component integration #577

Shashwat12-egov · 2024-09-23T06:36:10Z

No description provided.

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* added project valid check, fixed house type selection issue, added resource duplicate check * removed split code for boundary * fixed pop up not closing issue * removed credentials --------- Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* added project valid check, fixed house type selection issue, added resource duplicate check * removed split code for boundary * fixed pop up not closing issue * removed credentials * HCMPRE-412 - creating beneficiary for all individuals if not registered, reload event fix, removed dialog for loader of localization.dart * added check condition to show status and updated selection card * beneficiary_checklist.dart code compare with enum * fix state not getting updated issue (#557) Co-authored-by: rachana-egov <rachana.singh@egovernment.org> * Fixed dashboard chart delete fixes in isar (#558) * Resource validation added (#555) * added project valid check, fixed house type selection issue, added resource duplicate check * removed split code for boundary * fixed pop up not closing issue * removed credentials --------- Co-authored-by: rachana-egov <rachana.singh@egovernment.org> * Fixed dashboard chart delete fixes in isar * Update language_selection.dart --------- Co-authored-by: rachana-egov <137176770+rachana-egov@users.noreply.github.com> Co-authored-by: rachana-egov <rachana.singh@egovernment.org> Co-authored-by: Naveen Renati <154230258+naveenr-egov@users.noreply.github.com> * updated packages version and published --------- Co-authored-by: rachana-egov <rachana.singh@egovernment.org> Co-authored-by: rachana-egov <137176770+rachana-egov@users.noreply.github.com> Co-authored-by: Ramkrishna-egov <85437265+Ramkrishna-egov@users.noreply.github.com>

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

…ibrary to digit_ui_component library)

naveenr-egov

Resolve the comments. Use dart code format before commiting.

naveenr-egov · 2024-09-23T10:33:37Z

apps/health_campaign_field_worker_app/pubspec.lock

Why is this deleted

naveenr-egov · 2024-09-23T10:34:56Z

packages/attendance_management/pubspec.lock

Why is this deleted?

naveenr-egov · 2024-09-23T10:48:26Z

packages/referral_reconciliation/assets/animated_json/alert.json

Validate If assets are added in main app does it require at package level as well?

On removing from any of them it is giving error

naveenr-egov · 2024-09-23T10:52:42Z

packages/referral_reconciliation/lib/pages/create_referral/reason_checklist_preview.dart

- );
+ ServiceResetEvent(serviceList: serviceList),
+ );
+ context.router.popUntil((route) => route.settings.name == 'SearchReferralReconciliationsRoute');


Get name from the generatedRoute.page

Why is the navigation added now? It was not there in previous button function.

Changed the hard coded route name.
I have added the navigation here to navigate to the main page on clicking close button

naveenr-egov · 2024-09-23T11:49:57Z

packages/referral_reconciliation/lib/pages/create_referral/record_facility_details.dart

@@ -24,7 +25,7 @@ class ReferralFacilityPage extends LocalizedStatefulWidget {
 const ReferralFacilityPage({
 super.key,
 super.appLocalizations,
- this.isEditing = false,
+ this.isEditing = false,show


What is the usage of show variable?

I added to control the display property of the textfields but now it is fixed. I have removed it.

naveenr-egov · 2024-09-23T12:05:22Z

packages/referral_reconciliation/lib/pages/create_referral/record_referral_details.dart

+  final symptom = form
+  .control(
+  _referralReason)
+  .value as String;
 context


Why is this if condition removed?

naveenr-egov · 2024-09-23T12:06:28Z

packages/referral_reconciliation/lib/pages/project_facility/project_facility_selection.dart

- color:
- DigitTheme.instance.colors.alabasterWhite,
+ color: Colors.white,
+ // color:


Delete commented code

naveenr-egov · 2024-09-23T12:20:32Z

packages/referral_reconciliation/lib/pages/create_referral/record_reason_checklist.dart

 validator: (value) {
- if (((value == null || value == '') && item.required == true)) {
+ // Custom validation logic
+ if (((controller[index].text == '') && item.required == true)) {


Why is it changed from value?

Previously, we were using custom flutter component so it was populating the value with the textfield but now value is coming null so instead of value we are directly taking the value from form.

naveenr-egov · 2024-09-23T12:42:25Z

packages/referral_reconciliation/lib/pages/search_referral_reconciliations.dart

- builder: (context, state) {
- final router = context.router;
+ bottomNavigationBar: Card(
+ margin: const EdgeInsets.all(0),


Can remove margin since it's 0

No, we can not do that because Card is giving some margin by default so overwriting that margin with 0.

naveenr-egov · 2024-09-24T04:49:30Z

packages/referral_reconciliation/pubspec.lock

Why is this deleted?

coderabbitai · 2024-09-25T11:44:30Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

rachana-egov and others added 18 commits August 28, 2024 14:00

privacy policy config issue fix (#550)

7e42940

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

fixed text ellipse issue (#553)

78dd3f3

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

Resource validation added (#555)

f40558a

* added project valid check, fixed house type selection issue, added resource duplicate check * removed split code for boundary * fixed pop up not closing issue * removed credentials --------- Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

removed dialog closing function from language page (#560)

9ad9ea9

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

pulled from develop

9e5bbbf

pulled from develop

9b2c56d

pulled from develop

eb3be61

Made changes in referral reconciliation

b257b86

Made changes in referral reconciliation(Changed the digit_component l…

c8780a7

…ibrary to digit_ui_component library)

Made changes in referral reconciliation(Changed the digit_component l…

56d2f99

…ibrary to digit_ui_component library)

Changes in radiolist button

f288b7e

Fixed button issues and changed search bar component

a8bca6a

Added a value in i18 file

55ae7ab

lock files

fb40231

Made changes in HF referral widget files

ca5ffcc

Removed commented code

7e4c05a

Using digit-ui library from the published page

b153783

Shashwat12-egov requested review from naveen-egov and naveenr-egov September 23, 2024 06:36

naveenr-egov changed the base branch from checklist-package to pgr_survey_form_merge September 23, 2024 10:39

naveenr-egov requested changes Sep 24, 2024

View reviewed changes

Did all the asked changes on PR

d1abca0

Shashwat12-egov closed this Sep 25, 2024

Shashwat12-egov reopened this Sep 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hf referral new digit component integration #577

Hf referral new digit component integration #577

Shashwat12-egov commented Sep 23, 2024

naveenr-egov left a comment

naveenr-egov Sep 23, 2024

Shashwat12-egov Sep 25, 2024

naveenr-egov Sep 23, 2024

Shashwat12-egov Sep 25, 2024

naveenr-egov Sep 23, 2024

Shashwat12-egov Sep 25, 2024

naveenr-egov Sep 23, 2024

naveenr-egov Sep 23, 2024

Shashwat12-egov Sep 25, 2024

naveenr-egov Sep 23, 2024

Shashwat12-egov Sep 25, 2024

naveenr-egov Sep 23, 2024

Shashwat12-egov Sep 25, 2024

naveenr-egov Sep 23, 2024

Shashwat12-egov Sep 25, 2024

naveenr-egov Sep 23, 2024

Shashwat12-egov Sep 25, 2024

naveenr-egov Sep 23, 2024

Shashwat12-egov Sep 25, 2024

naveenr-egov Sep 24, 2024

Shashwat12-egov Sep 25, 2024

coderabbitai bot commented Sep 25, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Hf referral new digit component integration #577

Are you sure you want to change the base?

Hf referral new digit component integration #577

Conversation

Shashwat12-egov commented Sep 23, 2024

naveenr-egov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderabbitai bot commented Sep 25, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

CodeRabbit Configuration File (`.coderabbit.yaml`)