-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build-config.yml #573
base: master
Are you sure you want to change the base?
Conversation
Added build config for MDMS-v2
WalkthroughThe pull request introduces a new build configuration for the "MDMS-v2" service in the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: "builds/Digit-Core/core-services/MDMS-v2" | ||
build: | ||
- work-dir: "core-services/MDMS-v2" | ||
image-name: "NDNS-v2" | ||
dockerfile: "build/maven/Dockerfile" | ||
- work-dir: "core-services/MDMS-v2/src/main/resources/db" | ||
image-name: "MDMS-v2-db" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Resolve naming inconsistencies and image name discrepancies
The verification confirms several issues with the new configuration:
- The service name "MDMS-v2" is inconsistent with the existing lowercase "mdms-v2" configuration.
- The main service image name "NDNS-v2" does not align with the service name "MDMS-v2".
- Both "mdms-v2" and "MDMS-v2" configurations exist, indicating potential duplication.
Recommended Actions:
-
If this is an update to the existing service:
- Modify the existing "mdms-v2" configuration to ensure consistency in naming.
- Update the image name to align with the service name (e.g., use "mdms-v2" instead of "NDNS-v2").
-
If this is intended to be a new, separate service:
- Use consistent naming conventions (e.g., all lowercase or all uppercase).
- Ensure the image name reflects the service name appropriately (e.g., "MDMS-v2" instead of "NDNS-v2").
Ensure that all references across the codebase adhere to the chosen naming convention to maintain consistency and avoid confusion.
Analysis chain
Resolve naming inconsistencies and potential duplication
There are several issues with this new configuration:
- The service name "MDMS-v2" is inconsistent with the existing lowercase "mdms-v2" configuration.
- The main service image name "NDNS-v2" doesn't align with the service name "MDMS-v2".
- This configuration appears to duplicate the existing "mdms-v2" configuration (lines 179-185) with slight differences.
Consider the following actions:
- Decide whether this should be a new service or an update to the existing one. If it's an update, modify the existing "mdms-v2" configuration instead of adding a new one.
- If this is indeed a new service, ensure consistent naming:
- Use either all uppercase or all lowercase for the service name.
- Align the image name with the service name (e.g., use "MDMS-v2" instead of "NDNS-v2").
Here's a suggested correction if this is intended to be a new service:
- - name: "builds/Digit-Core/core-services/MDMS-v2"
+ - name: "builds/Digit-Core/core-services/mdms-v2-new"
build:
- work-dir: "core-services/MDMS-v2"
- image-name: "NDNS-v2"
+ image-name: "mdms-v2-new"
dockerfile: "build/maven/Dockerfile"
- work-dir: "core-services/MDMS-v2/src/main/resources/db"
- image-name: "MDMS-v2-db"
+ image-name: "mdms-v2-new-db"
If this is meant to replace the existing configuration, consider updating the existing one instead of adding a new configuration.
To check for any other occurrences or references to MDMS-v2 or NDNS-v2 in the codebase, run the following script:
This will help ensure consistency across the entire project.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
echo "Searching for MDMS-v2 references:"
rg -i "MDMS-v2"
echo "Searching for NDNS-v2 references:"
rg -i "NDNS-v2"
Length of output: 37996
Added build config for MDMS-v2
Summary by CodeRabbit