Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech TTS voice selector #2513

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Speech TTS voice selector #2513

wants to merge 3 commits into from

Conversation

panaC
Copy link
Member

@panaC panaC commented Aug 19, 2024

No description provided.

@panaC panaC self-assigned this Aug 19, 2024
@panaC panaC marked this pull request as draft August 19, 2024 13:57
@panaC panaC mentioned this pull request Aug 19, 2024
@panaC
Copy link
Member Author

panaC commented Aug 30, 2024

The tts voice is attached to the publication.
when first opening a publication, the tts voice is not set. The tts voice is updated only when opening the tts control panel not before. So the tts voice is not set on first reading until the user opens the control panel, the voice is in a undefined state.

when the tts voice has been updated in the control panel, the voice is attached and persisted to the publication.

default Voice :
image

default Voice accessible EPUB3 :
image

About the Localisation : the languages labels and regions labels in both combobox is translated with Intl.

TODO :

  • need to merge the readium-speech PR
  • update the npm package link to 'readium-speech' when pushed to NPM registry
  • need to improve the css margin of the ttsVoice component in control panel
  • need to discuss about the tts voice persistence across publication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant