fix: Synchronize EDR refresh #1633
Open
+1,169
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelmag110
requested review from
paullatzelsperger and
wolf4ood
and removed request for
paullatzelsperger
rafaelmag110
force-pushed
the
synchronize_edr_refresh
branch
from
aecad9a
to
944ff4d
Compare
core/edr-core/src/main/java/org/eclipse/tractusx/edc/edr/core/service/EdrServiceImpl.java
Outdated
Show resolved
Hide resolved
.../eclipse/tractusx/edc/edr/spi/testfixtures/index/lock/EndpointDataReferenceLockBaseTest.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/eclipse/tractusx/edc/edr/core/lock/DefaultEdrLockProviderExtension.java
Outdated
Show resolved
Hide resolved
core/edr-core/src/main/java/org/eclipse/tractusx/edc/edr/core/lock/InMemoryEdrLock.java
Outdated
Show resolved
Hide resolved
core/edr-core/src/main/java/org/eclipse/tractusx/edc/edr/core/lock/InMemoryEdrLock.java
Outdated
Show resolved
Hide resolved
| import org.junit.jupiter.api.BeforeEach; | ||
|
|
||
| @ComponentTest | ||
| class InMemoryEdrLockTest extends EndpointDataReferenceLockBaseTest { |
There was a problem hiding this comment.
tests for releaseLock missing. there should be some in the base test class, and specific tests in the in-mem test.
|
Actually, regarding the inmem lock; if access to the hashmap is atomic, the global lock isn't needed anymore. |
core/edr-core/src/main/java/org/eclipse/tractusx/edc/edr/core/lock/InMemoryEdrLock.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Introduces a synchronization mechanism with database locks that only allows one request to update an expired token at a time. All other requests wait until the first request updates the token and releases the database.
WHY
To fix the issue described in #1618
FURTHER NOTES
PR to bugfix/0.7.7 first because it's a priority to have that merged.
Closes #1618