Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(seeding): move company and address to overwrite dir #1067

Merged
merged 3 commits into from
Oct 17, 2024
Merged

feat(seeding): move company and address to overwrite dir #1067

merged 3 commits into from
Oct 17, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Oct 9, 2024 •
edited
Loading

Description

move company and address seeding files to overwrite dir

Why

to provide the option to seed the bpn without changing the code it's moved into a directory where it can be overwritten

Issue

Refs: eclipse-tractusx/portal#449

Corresponding Portal PR

eclipse-tractusx/portal#450

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 mentioned this pull request Oct 9, 2024
Merged
4 tasks
@Phil91 Phil91 marked this pull request as ready for review October 9, 2024 13:29
@Phil91 Phil91 added this to the Release 24.12 milestone Oct 9, 2024
evegufy
evegufy previously requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍
just, could we do the update of the api specs version in a separate pr?

@Phil91
Copy link
Member Author

Phil91 commented Oct 9, 2024 •
edited
Loading

lgtm 👍 just, could we do the update of the api specs version in a separate pr?

removed from here. will create a separate pr for that

@Phil91 Phil91 requested a review from evegufy October 9, 2024 20:49
@ntruchsess ntruchsess dismissed evegufy’s stale review October 15, 2024 20:11

as requested api spec changes were moved to separate pr

evegufy
evegufy requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just the api spec files should not be part of the change: could you please review #1077? And once it is merged, rebase to main?

Phil91 and others added 3 commits October 16, 2024 15:15
@Phil91
feat(seeding): moke company and address overwriteable
7684b63 
to provide the option to seed the bpn without changing the code it's moved into a directory where it can be overwritten

Refs: eclipse-tractusx/portal#449
@Phil91
chore: adjust seeding data
5501ff7 
Refs: #449
@ntruchsess @Phil91
cleanup
6bb1cc2
@Phil91 Phil91 requested a review from evegufy October 16, 2024 13:15
@Phil91
Copy link
Member Author

Phil91 commented Oct 16, 2024

Looks good in general, just the api spec files should not be part of the change: could you please review #1077? And once it is merged, rebase to main?

done

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

evegufy
evegufy approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully

@Phil91 Phil91 merged commit f4a371b into main Oct 17, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/449-seeding branch October 17, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy evegufy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 24.12
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @ntruchsess @evegufy