Skip to content

Commit

Permalink
Allow configuration of proxy-body size for instances-ingress (#29)
Browse files Browse the repository at this point in the history
Define the proxy-body-size value for instances-ingress and allow to customize it via the values file.
The proxy-body-size resembles the maximum allowed size of the client request body.
(e.g. relevant for file-uploads in the Theia application)
  • Loading branch information
ndoschek authored Jul 19, 2023
1 parent 68c317b commit 1ad6bd6
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/theia.cloud/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.8.0
version: 0.8.1-v001

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ metadata:
nginx.ingress.kubernetes.io/rewrite-target: /$2
nginx.ingress.kubernetes.io/configuration-snippet: |
proxy_set_header 'X-Forwarded-Uri' $request_uri;
nginx.ingress.kubernetes.io/proxy-body-size: {{ tpl (.Values.ingress.proxyBodySize | toString) . }}
spec:
{{- if .Values.hosts.tls }}
tls:
Expand Down
1 change: 1 addition & 0 deletions charts/theia.cloud/templates/instances-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ metadata:
nginx.ingress.kubernetes.io/rewrite-target: /$2
nginx.ingress.kubernetes.io/configuration-snippet: |
proxy_set_header 'X-Forwarded-Uri' $request_uri;
nginx.ingress.kubernetes.io/proxy-body-size: {{ tpl (.Values.ingress.proxyBodySize | toString) . }}
spec:
{{- if .Values.hosts.tls }}
tls:
Expand Down
4 changes: 4 additions & 0 deletions charts/theia.cloud/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,10 @@ ingress:
# common-name
theiaCloudCommonName: false

# Sets the maximum allowed size of the client request body inside the application (e.g. file uploads in Theia).
# Defaults to 1m. Setting size to 0 disables checking of client request body size.
proxyBodySize: 1m

operatorrole:
name: operator-api-access

Expand Down

0 comments on commit 1ad6bd6

Please sign in to comment.