Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86: Implement Integer/Long . compress/expand intrinsics #19751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

x86: Implement Integer/Long . compress/expand intrinsics #19751

wants to merge 1 commit into from

Conversation

BradleyWood
Copy link
Member

No description provided.

@BradleyWood
x86: Implement Integer/Long . compress/expand
59111b6 
Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
@BradleyWood BradleyWood changed the title x86: Implement Integer/Long . compress/expand x86: Implement Integer/Long . compress/expand intrinsics Jun 24, 2024
@BradleyWood BradleyWood requested review from 0xdaryl and removed request for dsouzai June 24, 2024 18:47
@BradleyWood BradleyWood marked this pull request as draft August 15, 2024 17:50
@BradleyWood BradleyWood marked this pull request as ready for review October 3, 2024 13:14
@BradleyWood
Copy link
Member Author

Depends on eclipse/omr#7392

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 3, 2024

The depends:omr:breaking label means the two PRs are dependent and must be merged together, something I don't want to do unless it is truly necessary. The OMR PR looks to be introducing new instructions only. Is this label warranted here?

@BradleyWood
Copy link
Member Author

I don't agree. They aren't co-dependent but this PR cannot be merged until the OMR PR is merged, otherwise the build will break.

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 3, 2024

What you want is the depends:omr tag then.

@BradleyWood BradleyWood added depends:omr Pull request is dependent on a corresponding change in OMR and removed depends:omr:breaking labels Oct 3, 2024
@pshipton
Copy link
Member

pshipton commented Oct 3, 2024

this PR cannot be merged until the OMR PR is merged

FYI the OMR PR not only needs to be merged, it needs to go through the OpenJ9 OMR acceptance testing and get promoted to the OpenJ9 project.

@dsouzai
Copy link
Contributor

dsouzai commented Oct 3, 2024

FYI the OMR PR not only needs to be merged, it needs to go through the OpenJ9 OMR acceptance testing and get promoted to the OpenJ9 project.

Just for clarity, this means the changes need to be in the openj9 branch of https://github.com/eclipse-openj9/openj9-omr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl

Assignees

@0xdaryl 0xdaryl

Labels
arch:x86 comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BradleyWood @0xdaryl @pshipton @dsouzai