Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chunksize to vchunk interface #572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JacksonYao287
Copy link
Contributor

when implementing fixed pg size, we need to know the exact size of a real chunk. add this interface to support this function.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.88%. Comparing base (1a0cef8) to head (e6d0ad4).
Report is 80 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/device/vchunk.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #572       +/-   ##
===========================================
+ Coverage   56.51%   66.88%   +10.37%     
===========================================
  Files         108      109        +1     
  Lines       10300    10585      +285     
  Branches     1402     1430       +28     
===========================================
+ Hits         5821     7080     +1259     
+ Misses       3894     2825     -1069     
- Partials      585      680       +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoxichen
Copy link
Collaborator

can we targeting all fix_pg_size change to a branch and tested ?

@JacksonYao287
Copy link
Contributor Author

can we targeting all fix_pg_size change to a branch and tested ?

ATM, actually, I am not quite sure how many changes will we exactly need for fix pg size. so I add this small step here, so that it will not block the initial development of fixed pg size feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants