Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix long duration of write_to_full test case and max_io test case #533

Closed
wants to merge 13 commits into from

Conversation

yamingk
Copy link
Contributor

@yamingk yamingk commented Aug 29, 2024

  1. change max_io size to 60MB which will fit in with existing portion nblks with 4GB min chunk size;
  2. change write_to_full case to allow use file for testing to complete sooner. The original purpose of this test case is to see what meta svc will behave after writing laste byte of its vdev. If with real drives, it will take around 3 days to complete this single test case. We can choose to remove --use_file if we do really want to test that long with meta svc some day...

Testing:

  1. both max io test case and write to full test case passed by manual run on real drives.
  2. a new round of meta svc long run is kicked off and waiting to complete (will merge after a full round passed).

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.89%. Comparing base (1a0cef8) to head (6fc2f85).
Report is 57 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #533       +/-   ##
===========================================
+ Coverage   56.51%   67.89%   +11.38%     
===========================================
  Files         108      109        +1     
  Lines       10300    10435      +135     
  Branches     1402     1400        -2     
===========================================
+ Hits         5821     7085     +1264     
+ Misses       3894     2681     -1213     
- Partials      585      669       +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xiaoxichen
xiaoxichen previously approved these changes Aug 30, 2024
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

JacksonYao287
JacksonYao287 previously approved these changes Aug 30, 2024
Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@xiaoxichen xiaoxichen dismissed stale reviews from JacksonYao287 and themself via ee71ec6 August 30, 2024 04:55
yamingk and others added 10 commits September 3, 2024 09:46
return empty string upon failed client lookup
before install snapshot completes, raft_server()->get_committed_log_idx() will be the same if write_snapshot_data is called several times, so that snp_data->offset can not be updated to new cursor.
this PR use a separate last_data_committed_lsn to maintain the last committed lsn for writing data, which is use for updating
snp_data->offset in write_snapshot_data
* horten log store test

* remove android in Setup Conan phrase
@yamingk yamingk closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants