Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Upgrade in LogstoreFamily #129

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix Upgrade in LogstoreFamily #129

merged 1 commit into from
Jul 17, 2023

Conversation

shosseinimotlagh
Copy link
Contributor

@shosseinimotlagh shosseinimotlagh commented Jul 17, 2023

Maintaining Compatibility for different versions
In previous versions of AM image, i.e., AM20, m_metablk_name was populated with LogDevFamily. In the recent, m_metablk_name had been changed to LogStoreFamily which results in broken recovery procedure from older versions. In this PR I revert it back that upgrading from AM -20 to AM21 will be possible.

Copy link
Contributor

@raakella1 raakella1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Please add a write-up explaining why this change is necessary

@codecov-commenter
Copy link

Codecov Report

Merging #129 (36cb64b) into stable/v3.x (523f6ae) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           stable/v3.x     #129      +/-   ##
===============================================
+ Coverage        45.33%   45.36%   +0.02%     
===============================================
  Files              126      126              
  Lines            16348    16353       +5     
  Branches          1939     1942       +3     
===============================================
+ Hits              7412     7418       +6     
- Misses            8227     8232       +5     
+ Partials           709      703       -6     
Impacted Files Coverage Δ
src/homelogstore/log_store_family.cpp 46.19% <100.00%> (ø)

... and 8 files with indirect coverage changes

@shosseinimotlagh shosseinimotlagh merged commit 7c2ff1a into eBay:stable/v3.x Jul 17, 2023
16 checks passed
@shosseinimotlagh shosseinimotlagh deleted the fix_logstorefamily branch August 9, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants