Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert dump content in logstore/Metablk to base64 encoded format and add Metablk object view #123

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

shosseinimotlagh
Copy link
Contributor

@shosseinimotlagh shosseinimotlagh commented Jul 5, 2023

Sample:
python hs_http_cli_tool.py get_object --name=MetaBlkMgr
python hs_http_cli_tool.py cli_tool get_object --type=MetaBlk
python hs_http_cli_tool.py get_object --type=MetaBlk --batch_size=3 --next
python hs_http_cli_tool.py get_object --name=MetaBlk_LogStoreFamily0 --verbosity=2
python hs_http_cli_tool.py get_object --name=MetaBlk_LogStoreFamily0 --verbosity=3

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #123 (fcf284d) into stable/v3.x (4923483) will decrease coverage by 0.22%.
The diff coverage is 7.92%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           stable/v3.x     #123      +/-   ##
===============================================
- Coverage        45.53%   45.31%   -0.22%     
===============================================
  Files              126      126              
  Lines            16268    16360      +92     
  Branches          1924     1943      +19     
===============================================
+ Hits              7408     7414       +6     
- Misses            8155     8237      +82     
- Partials           705      709       +4     
Impacted Files Coverage Δ
src/api/meta_interface.hpp 100.00% <ø> (ø)
src/engine/common/homestore_utils.cpp 34.04% <0.00%> (-25.22%) ⬇️
src/homeblks/homeblks_http_server.cpp 20.09% <0.00%> (ø)
src/homeblks/volume/volume.hpp 52.94% <ø> (ø)
src/homelogstore/log_store.cpp 35.78% <0.00%> (-1.09%) ⬇️
src/engine/meta/meta_blks_mgr.cpp 25.06% <11.59%> (-1.47%) ⬇️

... and 8 files with indirect coverage changes

@yamingk
Copy link
Contributor

yamingk commented Jul 6, 2023

Can we add a new test case to cover this functionality?

@shosseinimotlagh shosseinimotlagh changed the title Convert dump content in logstore to base64 encoded format Convert dump content in logstore/Metablk to base64 encoded format and add Metablk object view Jul 12, 2023
src/engine/meta/meta_blks_mgr.cpp Outdated Show resolved Hide resolved
src/api/meta_interface.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@szmyd szmyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shosseinimotlagh shosseinimotlagh merged commit dd44ed2 into eBay:stable/v3.x Jul 13, 2023
16 checks passed
@shosseinimotlagh shosseinimotlagh deleted the SDSTOR-encode branch November 13, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants