-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert dump content in logstore/Metablk to base64 encoded format and add Metablk object view #123
Convert dump content in logstore/Metablk to base64 encoded format and add Metablk object view #123
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## stable/v3.x #123 +/- ##
===============================================
- Coverage 45.53% 45.31% -0.22%
===============================================
Files 126 126
Lines 16268 16360 +92
Branches 1924 1943 +19
===============================================
+ Hits 7408 7414 +6
- Misses 8155 8237 +82
- Partials 705 709 +4
|
Can we add a new test case to cover this functionality? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sample:
python hs_http_cli_tool.py get_object --name=MetaBlkMgr
python hs_http_cli_tool.py cli_tool get_object --type=MetaBlk
python hs_http_cli_tool.py get_object --type=MetaBlk --batch_size=3 --next
python hs_http_cli_tool.py get_object --name=MetaBlk_LogStoreFamily0 --verbosity=2
python hs_http_cli_tool.py get_object --name=MetaBlk_LogStoreFamily0 --verbosity=3