-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(uirefresh): component refresh - trade box [2/2] #1214
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -69,7 +71,7 @@ export const ToggleGroup = forwardRefFn( | |||
<$ToggleButton | |||
size={size ?? (isTablet ? ButtonSize.Small : ButtonSize.XSmall)} | |||
shape={shape} | |||
disabled={item.disabled} | |||
disabled={item.disabled ?? disabled} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be || ?
@@ -199,6 +200,10 @@ class AbacusStateManager { | |||
this.setTradeValue({ value: null, field: TradeInputField.leverage }); | |||
} | |||
|
|||
if (uiRefresh && needsTargetLeverage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just clear them all the time? I worry about edge cases where target leverage is entered but then needsTargetLeverage becomes false before this clear function is called and we just leave it there forever.
Figma
slotTrigger
ofTradeTableSettings
)To follow up on:
Views
<TargetLeverageButton>
<TradeSizeInputs>
TargetLeverageInput
component when necessaryNew:
<TargetLeverageInput>
AdjustTargetLeverageForm
. Did not bother refactoring to share this component since that component can be deprecated whenuiRefresh
is launched<MarginAndLeverageButtons>
<MarginModeSelector>
<TradeBoxOrderView>
<TradeTableSettings>
Components
<ToggleGroup>
Functions/Clients
lib/abacus/index.ts