feat(uirefresh): component refresh - trade box [2/2] #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tyleroooo
reviewed
Oct 24, 2024
| @@ -69,7 +71,7 @@ export const ToggleGroup = forwardRefFn( | |||
| <$ToggleButton | |||
| size={size ?? (isTablet ? ButtonSize.Small : ButtonSize.XSmall)} | |||
| shape={shape} | |||
| disabled={item.disabled} | |||
| disabled={item.disabled ?? disabled} | |||
| @@ -199,6 +200,10 @@ class AbacusStateManager { | |||
| this.setTradeValue({ value: null, field: TradeInputField.leverage }); | |||
| } | |||
|
|
|||
| if (uiRefresh && needsTargetLeverage) { | |||
There was a problem hiding this comment.
Why not just clear them all the time? I worry about edge cases where target leverage is entered but then needsTargetLeverage becomes false before this clear function is called and we just leave it there forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figma
slotTriggerofTradeTableSettings)To follow up on:
Views
<TargetLeverageButton><TradeSizeInputs>TargetLeverageInputcomponent when necessaryNew:
<TargetLeverageInput>AdjustTargetLeverageForm. Did not bother refactoring to share this component since that component can be deprecated whenuiRefreshis launched<MarginAndLeverageButtons><MarginModeSelector><TradeBoxOrderView><TradeTableSettings>Components
<ToggleGroup>Functions/Clients
lib/abacus/index.ts