-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: favoriting markets #1197
base: main
Are you sure you want to change the base?
feat: favoriting markets #1197
Conversation
aforaleka
commented
Oct 22, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
58e2994
to
3360e3c
Compare
38f4284
to
2d34d6a
Compare
3360e3c
to
19160b2
Compare
19160b2
to
62286a5
Compare
</span> | ||
{useStackedStyle ? ( | ||
showStackedVolume ? ( | ||
<Output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm I don't love building in volume
to this generic component, can we use the children
prop instead to pass through the styled volume where it's needed?
@@ -229,6 +234,7 @@ export const useMarketsData = ({ | |||
tickSizeDecimals, | |||
trades24H: 0, | |||
volume24H: 0, | |||
isFavorite: favoritedMarkets.includes(`${id}-USD`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rip I wish we had a helper somewhere like getMarketIdFromAssetName
?