-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: builds with skip client #1191
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
393f229
to
1411437
Compare
15ac51b
to
3df93de
Compare
f4e8397
to
fc5b2cd
Compare
@@ -4300,6 +4280,16 @@ packages: | |||
utility-types: 3.10.0 | |||
dev: false | |||
|
|||
/@keplr-wallet/unit@0.12.143(starknet@6.11.0): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of new dupes in here :(
main chunk is 23,957.98 kB, which isn't terrible, but i guess it is +50% which is sad |
yeah it's still a big increase but they're working on another patch that will further decrease the bundle size by ~6MB so it's getting better 👍 |
fe286db
to
c81f4b4
Compare
This is a quick patch to get builds consistently working.
The skip team has released a version of their client that shaves off ~7MB from the bundle size (new bundle size is around ~44MB instead of ~51MB).
This improvement along with an increase in the node heap to 6GB is enough to get builds working.
This is NOT the end of the journey. Skip is working on rebuilding some functionality in-house to reduce the bundle size by up to 6MB more 😮 . Once those changes are in we'll probably be able to remove the node heap size override.
Why 6GB?
The vercel container has 8GB of memory, <2 of which is taken by the container itself (running OS/infra). This is in line with vercel's recommendation.