fix: builds with skip client #1191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yogurtandjam
changed the base branch from
main
to
jerms/OTE-855_cctp-withdrawals-5
yogurtandjam
force-pushed
the
jerms/OTE-855_cctp-withdrawals-5
branch
from
393f229
to
1411437
Compare
yogurtandjam
force-pushed
the
test-build-size
branch
from
15ac51b
to
3df93de
Compare
yogurtandjam
force-pushed
the
test-build-size
branch
from
f4e8397
to
fc5b2cd
Compare
tyleroooo
reviewed
Oct 23, 2024
| @@ -4300,6 +4280,16 @@ packages: | |||
| utility-types: 3.10.0 | |||
| dev: false | |||
|
|
|||
| /@keplr-wallet/unit@0.12.143(starknet@6.11.0): | |||
There was a problem hiding this comment.
lots of new dupes in here :(
|
main chunk is 23,957.98 kB, which isn't terrible, but i guess it is +50% which is sad |
yeah it's still a big increase but they're working on another patch that will further decrease the bundle size by ~6MB so it's getting better 👍 |
yogurtandjam
force-pushed
the
test-build-size
branch
from
fe286db
to
c81f4b4
Compare
tyleroooo
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick patch to get builds consistently working.
The skip team has released a version of their client that shaves off ~7MB from the bundle size (new bundle size is around ~44MB instead of ~51MB).
This improvement along with an increase in the node heap to 6GB is enough to get builds working.
This is NOT the end of the journey. Skip is working on rebuilding some functionality in-house to reduce the bundle size by up to 6MB more 😮 . Once those changes are in we'll probably be able to remove the node heap size override.
Why 6GB?
The vercel container has 8GB of memory, <2 of which is taken by the container itself (running OS/infra). This is in line with vercel's recommendation.