Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate deposit prior adding to the wallet #1040

Merged
merged 2 commits into from
May 3, 2019
Merged

Validate deposit prior adding to the wallet #1040

merged 2 commits into from
May 3, 2019

Commits on May 2, 2019

  1. Validate deposit prior adding to the wallet 

    At the moment, when a user prepares deposit, the node creates a transaction and adds it to the
wallet.  It, in turn, tries to accept it to the memory pool and could fail when the deposit is
invalid (for example validator is blacklisted). That leads to disappearing of the deposit from the
balance.

This commit fixes that by validating deposit before adding transaction to the wallet.

Fixes dtr-org#996.

Signed-off-by: Stanislav Frolov <stanislav@thirdhash.com>
    @frolosofsky
    frolosofsky committed May 2, 2019
    Configuration menu
    Copy the full SHA
    a82993b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into salvage-deposit

    @frolosofsky
    frolosofsky authored May 2, 2019
    Configuration menu
    Copy the full SHA
    2ee0f9c View commit details
    Browse the repository at this point in the history