Merge with Tristan's fork #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting points from a surfel
… works for small w
…to always have valid embedders.
This bug occurs when exporting results to png. It is mayby related to the fact that many qapplication are initialized in the same program (even if they are correctly destroyed meanwhile). Related bug report could be: https://bugreports.qt.io/browse/QTBUG-35437 Solution was to instanciate Qt once at the program startup and to request instance when needed.
With previous version, many snapshots was wrong (blurred or copy of the screen behind the QGLViewer windows). It has been solved by connecting the snapshot action to the signal emited when the render is finished. See for example: http://www.libqglviewer.com/refManual/classQGLViewer.html#a1cf2ffb973b096b249dc7e90327a2a8e The previous commit (using only one QApplication) has induce a bug: QGLViewer index increases at each snapshot, so that que camera configuration management is not anymore appropriate (many errors while trying to rename .qglviewer.xml). TODO
There's still a bug on beginning (in deformation2d too): when initially in contact, the phases seems to shift away from each other at the first iteration.
The label is updated for phases which field value is >= 0.5. The problem is that, when using more than 2 phases, and when (at least) triple contact point exists, the renormalization of the phases leads to a neighbourhoud of this point where no phase have field >= 0.5. The phase with default label (ie the background) was then polluting this zone. The proposed solution (draft) is to assigned the label to the phase with maximum field value. That implies to consider the background as a phase (with an evolution equation ?).
To avoid using new value instead of the old ones.
It is now the default format, as the write speed is faster. VTK files seems to be in Little Endian by default. TODO: support for VTK XML format (so the endianness can be specified).
The current workaround was to add a phase-accessor to the MultiPhaseField evolver. The export in deformation3d.cpp need to cleaned.
The dimension is fixed by a preprocessor macro. The two versions are very similar and differs mainly for the IO part. The VTKWriter works the same, regardless of the dimension.
CConstImage instead of CImage.
... by brute force : namespace DGtal {}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a merge from troussil's fork using partitionEvolverPhaseField and master branches.
Modifications have been made in respect with DGtal evolution (currently, only for deformations folder)