Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FAISS to env #2

Merged
merged 2 commits into from
Jan 13, 2024
Merged

add FAISS to env #2

merged 2 commits into from
Jan 13, 2024

Conversation

ykumards
Copy link
Contributor

Having a vector database would be useful for the competition. FAISS is a fairly popular option and has permissible license.

Copy link
Collaborator

@chrisjkuch chrisjkuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ykumards- Thanks for the proposed change! Makes sense to add faiss.

We had an issue with the GH build workflow that I believe we've fixed upstream. Can you rebase and re-submit?

In addition, we've occasionally had issues with certain faiss releases in the past - can you add it to the list of packages in runtime/tests/test_packages.py, and also add a quick test that it works as expected in the GPU environment?

Something like:

@pytest.mark.skipif(not GPU_AVAILABLE, reason="No GPU available")
def test_faiss_n_gpus():
    import faiss
    assert faiss.get_num_gpus() > 0

should hopefully suffice (this exact snippet is untested).

Thanks!

@ykumards
Copy link
Contributor Author

Hi @chrisjkuch, I added the tests. Let me know if it looks good, thanks!

Copy link
Collaborator

@chrisjkuch chrisjkuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@chrisjkuch chrisjkuch merged commit 145c77f into drivendataorg:main Jan 13, 2024
2 checks passed
@ykumards ykumards deleted the add-faiss branch January 14, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants