Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stream-based rabbit mq bus #490

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

sarmis
Copy link
Contributor

@sarmis sarmis commented Sep 17, 2023

I messed up during the update of the branch so I had to open a new PR

@catcherwong
Copy link
Member

/cc @Memoyu

@Memoyu
Copy link
Contributor

Memoyu commented Sep 19, 2023

I messed up during the update of the branch so I had to open a new PR

The version number does not need to be adjusted. Could you please rebase latest changes?

@Memoyu
Copy link
Contributor

Memoyu commented Sep 19, 2023

I'm very sorry. You can restore the original version number. We will make adjustments later. Thank you.

@sarmis
Copy link
Contributor Author

sarmis commented Sep 19, 2023

I'm very sorry. You can restore the original version number. We will make adjustments later. Thank you.

Not sure what you would like me to do, the only change on version.props is
<EasyCachingRabbitStreamBusPackageVersion>1.9.1</EasyCachingRabbitStreamBusPackageVersion>

do you want me to remove this line also?

@Memoyu
Copy link
Contributor

Memoyu commented Sep 19, 2023

I'm very sorry. You can restore the original version number. We will make adjustments later. Thank you.

Not sure what you would like me to do, the only change on version.props is <EasyCachingRabbitStreamBusPackageVersion>1.9.1</EasyCachingRabbitStreamBusPackageVersion>

do you want me to remove this line also?

Sorry, I didn't make it clear. You can add this line, but the version number should be 1.9.0

@sarmis
Copy link
Contributor Author

sarmis commented Sep 19, 2023

I'm very sorry. You can restore the original version number. We will make adjustments later. Thank you.

Not sure what you would like me to do, the only change on version.props is <EasyCachingRabbitStreamBusPackageVersion>1.9.1</EasyCachingRabbitStreamBusPackageVersion>
do you want me to remove this line also?

Sorry, I didn't make it clear. You can add this line, but the version number should be 1.9.0

But the rest in the file are in 1.9.1 already

@Memoyu
Copy link
Contributor

Memoyu commented Sep 19, 2023

I'm very sorry. You can restore the original version number. We will make adjustments later. Thank you.

Not sure what you would like me to do, the only change on version.props is <EasyCachingRabbitStreamBusPackageVersion>1.9.1</EasyCachingRabbitStreamBusPackageVersion>
do you want me to remove this line also?

Sorry, I didn't make it clear. You can add this line, but the version number should be 1.9.0

But the rest in the file are in 1.9.1 already

Okay, you are right, I saw it wrong! Thank you for the PR

@Memoyu Memoyu merged commit a39a5bf into dotnetcore:dev Sep 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants